Skip to content

UI/remove compoenent badges#4

Merged
TerrifiedBug merged 7 commits intomainfrom
ui/remove-compoenent-badges
Mar 4, 2026
Merged

UI/remove compoenent badges#4
TerrifiedBug merged 7 commits intomainfrom
ui/remove-compoenent-badges

Conversation

@TerrifiedBug
Copy link
Owner

No description provided.

@github-actions github-actions bot added documentation Improvements or additions to documentation docker ci labels Mar 4, 2026
@greptile-apps
Copy link

greptile-apps bot commented Mar 4, 2026

Greptile Summary

This PR simplifies the pipeline editor UI by removing data type badges (Log/Metric/Trace) and config summary previews from source, transform, and sink nodes. The changes also add path filters to CI workflows to prevent unnecessary builds, add screenshots to README documentation, and align the dev docker-compose configuration with production by adding the backups volume mount.

Key Changes:

  • Removed Badge component usage and getConfigSummary helper from all three node types
  • Simplified node display logic to show only live metrics (events/sec, bytes/sec) when available
  • Added paths filters to CI and CodeQL workflows, preventing runs on doc-only changes
  • Updated README with actual screenshot URLs from GitHub CDN
  • Added backups volume to docker-compose.dev.yml to match production setup

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • All changes are well-contained: UI simplifications remove unused code properly, workflow improvements add sensible optimizations, and docker-compose changes align dev with production. No logic errors, security issues, or breaking changes detected.
  • No files require special attention

Important Files Changed

Filename Overview
.github/workflows/ci.yml added path filters to prevent unnecessary CI runs and refined image tagging strategy
src/components/flow/sink-node.tsx removed data type badges and config summary display to simplify node UI
src/components/flow/source-node.tsx removed data type badges and config summary display to simplify node UI
src/components/flow/transform-node.tsx removed data type badges and config summary display to simplify node UI

Last reviewed commit: 4f4dfaa

Comment on lines 42 to 45
server-image:
name: Server Image
needs: check
if: github.event_name == 'push'
runs-on: ubuntu-latest
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing the if: github.event_name == 'push' condition means images will be pushed to the registry on every PR (since push: true on line 79). this will pollute the registry with unreviewed code and cause all PRs to overwrite the same dev tag

Suggested change
server-image:
name: Server Image
needs: check
if: github.event_name == 'push'
runs-on: ubuntu-latest
server-image:
name: Server Image
needs: check
if: github.event_name == 'push'
runs-on: ubuntu-latest

Comment on lines 86 to 89
agent-image:
name: Agent Image
needs: check
if: github.event_name == 'push'
runs-on: ubuntu-latest
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same issue - removing if: github.event_name == 'push' will cause agent images to be pushed on every PR

Suggested change
agent-image:
name: Agent Image
needs: check
if: github.event_name == 'push'
runs-on: ubuntu-latest
agent-image:
name: Agent Image
needs: check
if: github.event_name == 'push'
runs-on: ubuntu-latest

@TerrifiedBug TerrifiedBug merged commit ffe4e97 into main Mar 4, 2026
9 checks passed
@TerrifiedBug TerrifiedBug deleted the ui/remove-compoenent-badges branch March 4, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci docker documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant